-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[v18] access_monitoring_rules: Add timezone to schedules spec #60282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Allow empty timezone value - Reference IANA in error message - Add additional timeonze test cases
Amplify deployment status
|
Optional: | ||
|
||
- `shifts` (Attributes List) Shifts contains a set of shifts that make up the schedule. Shifts are configured in UTC. (see [below for nested schema](#nested-schema-for-specschedulestimeshifts)) | ||
- `shifts` (Attributes List) Shifts contains a set of shifts that make up the schedule. (see [below for nested schema](#nested-schema-for-specschedulestimeshifts)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version are we planning to include the new fields? If it's a minor one, let's specify which one it is so users on a lower minor version don't get confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I misinterpreted your previous comment. I thought you were noting that we should document the version requirements in the documentation guides.
This should be added into the next v18 release. I'll go ahead and add a note in the terraform docs as well.
Backport #60067 to branch/v18