feat: Add filtering and sort to tctl bots instances ls
#60273
+240
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change extends
tctl bots instances ls
to support filtering and sort. These features are already available in theListBotInstances
rpc. It also removes thegeneration
field from the output if favour ofversion
.Registered the
--format
flag - while it was supported in code, it wasn't added as a flag to the command.Changelog: Added filter and sort flags to
tctl bots instances ls
Updates: #55926
Changes
--format
,--search
,--query
,--sort-index
and--sort-order
flagstctl bots instances ls
Demo
Fuzzy search for "github" sorted by hostname

Filter by bot name sorted with most recent first

Advanced query for versions and join method showing oldest versions first

Reviewer notes
Here's a script to insert a bunch of bot instances to make testing easier; bot_instances.sql
The bots for these instances wont exist, but that not a problem within the scope of this change.
Be sure to restart your cluster afterwards - the cache will not be notified of the changes.
Delete all instances afterwards to tidy up, if you like;