Return UnknownEvent for malformed events #60121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rana
approved these changes
Oct 11, 2025
|
Is it possible to avoid using unknown here and fallback to the correct event that we miss? |
|
@tigrato we could for scp events. For any other malformed events, I don't think there's a way to know ahead of time which event to correct to. |
Can we do both here? I agree that an unknown event in the ui is better than an error that prevents viewing any events. However, for the SCP case, can we detect the error and create the appropriate event so it isn't display as an unknown event? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
events.FromEventFieldsto return unknown event when an event fails to unmarshal, instead of the unmarshal error. This prevents a single malformed audit event from breaking the entire webui audit log.Follow-up to #59882.
Changelog: Fixed malformed audit events breaking the audit log