Skip to content

[v17] Bump Go to 1.24.9 ⬆️ #60114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 15, 2025
Merged

[v17] Bump Go to 1.24.9 ⬆️ #60114

merged 9 commits into from
Oct 15, 2025

Conversation

cthach
Copy link
Contributor

@cthach cthach commented Oct 9, 2025 •
edited
Loading

Backports #60094.

Changelog: Updated Go to 1.24.9.

@cthach cthach self-assigned this Oct 9, 2025
@cthach cthach added go Issues related to Go builds/tooling backport dependencies Pull requests that update a dependency file size/sm chore labels Oct 9, 2025
@cthach cthach force-pushed the cthach/bump-go-1.24.8-v17 branch from c4d7d9d to 8d3653e Compare October 9, 2025 19:08
@cthach cthach force-pushed the cthach/bump-go-1.24.8-v17 branch from 65b8ad8 to 8775d3a Compare October 14, 2025 15:56
@cthach cthach changed the title [v17] Bump Go to 1.24.8 ⬆️ [v17] Bump Go to 1.24.9 ⬆️ Oct 14, 2025
@cthach cthach added the security Security Issues label Oct 14, 2025
@cthach cthach marked this pull request as ready for review October 14, 2025 17:22
@cthach
Copy link
Contributor Author

cthach commented Oct 14, 2025

Holding off until https://github.com/gravitational/teleport.e/pull/7412 is merged

rosstimothy
rosstimothy reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the examples updates were dropped here?

@cthach
Copy link
Contributor Author

cthach commented Oct 14, 2025

It looks like the examples updates were dropped here?

@rosstimothy

One is still on Go 1.22

teleport/examples/teleport-usage/go.mod

Line 3 in 9ffcfa1

go 1.22

Others are on Go 1.23.0

teleport/examples/access-plugin-minimal/go.mod

Lines 3 to 4 in 9ffcfa1

go 1.23.0

teleport/examples/api-sync-roles/go.mod

Lines 3 to 4 in 9ffcfa1

go 1.23.0

teleport/examples/desktop-registration/go.mod

Lines 3 to 4 in 9ffcfa1

go 1.23.0

teleport/examples/go-client/go.mod

Lines 3 to 4 in 9ffcfa1

go 1.23.0

teleport/examples/service-discovery-api-client/go.mod

Lines 3 to 4 in 9ffcfa1

go 1.23.0

I left them out because I assumed it was deliberate.

Did you want me to try bumping them all to 1.24.9?

@rosstimothy
Copy link
Contributor

I left them out because I assumed it was deliberate.

Did you want me to try bumping them all to 1.24.9?

I think we've just historically been bad about updating the examples. Let's bump them to the latest version here and we can reconsider our approach going forward.

@cthach
Bump example Go versions
03f37e6 
Signed-off-by: Chris Thach <[email protected]>
@cthach cthach marked this pull request as draft October 14, 2025 23:35
cthach
cthach commented Oct 14, 2025
View reviewed changes
@cthach cthach marked this pull request as ready for review October 15, 2025 13:02
@cthach cthach added this pull request to the merge queue Oct 15, 2025
Merged via the queue into branch/v17 with commit 2bb80ec Oct 15, 2025
45 of 46 checks passed
@cthach cthach deleted the cthach/bump-go-1.24.8-v17 branch October 15, 2025 13:31
@fheinecke fheinecke mentioned this pull request Oct 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rosstimothy rosstimothy rosstimothy approved these changes

@russjones russjones Awaiting requested review from russjones russjones is a code owner

@r0mant r0mant Awaiting requested review from r0mant r0mant is a code owner

@hugoShaka hugoShaka Awaiting requested review from hugoShaka hugoShaka is a code owner

@tigrato tigrato Awaiting requested review from tigrato tigrato is a code owner

@strideynet strideynet Awaiting requested review from strideynet strideynet is a code owner

@fheinecke fheinecke Awaiting requested review from fheinecke fheinecke is a code owner

@camscale camscale Awaiting requested review from camscale camscale is a code owner

@doggydogworld doggydogworld Awaiting requested review from doggydogworld doggydogworld is a code owner

@espadolini espadolini Awaiting requested review from espadolini

@marcoandredinis marcoandredinis Awaiting requested review from marcoandredinis

@zmb3 zmb3 Awaiting requested review from zmb3 zmb3 is a code owner

Assignees

@cthach cthach

Labels

backport chore dependencies Pull requests that update a dependency file go Issues related to Go builds/tooling security Security Issues size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cthach @rosstimothy @marcoandredinis @espadolini @zmb3