send message when giving up on join attempt #60110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
no-changelog
avatus
approved these changes
Oct 10, 2025
zmb3
approved these changes
Oct 12, 2025
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
nklaassen
force-pushed
the
nklaassen/iam
branch
from
12c2d8c to
ae4f52b
Compare
nklaassen
force-pushed
the
nklaassen/givingup
branch
from
b11d4c7 to
396b200
Compare
nklaassen
force-pushed
the
nklaassen/iam
branch
from
ae4f52b to
27e143b
Compare
Co-authored-by: Michael <[email protected]>
nklaassen
force-pushed
the
nklaassen/givingup
branch
from
396b200 to
23f464f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GivingUp message that joining clients (hosts or bots) will send when they give up on a join attempt due to some error. This should help when debugging hosts or bots that are failing to join a cluster, as they are now able to send context about why they are failing to the auth server, which will include that message in a log message and audit event. This was prompted by Edoardo's comment on RFD 27e here https://github.com/gravitational/teleport.e/pull/6963#discussion_r2250796633