Skip to content

Conversation

smallinsky
Copy link
Contributor

@smallinsky smallinsky commented Oct 8, 2025

What

Fix the issue illegibility reconciliation infinity loop when the eligibility status is set to NOT_EXISTING

After applying https://github.com/gravitational/teleport.e/pull/7296#discussion_r2363091256 (merge only to master) where the eligibility status is set to NOT_EXISTING the setMemberEligibility setOwnersEligibility should handle the case where the eligibility was set explicitly and only the case when Eligibilityis "", or Undefined should cause setting the default value.

@smallinsky smallinsky force-pushed the smallinsky/fix-setting-default-eligibility branch from f587f9b to ddccc65 Compare October 8, 2025 14:52
@smallinsky smallinsky marked this pull request as ready for review October 8, 2025 14:53
@github-actions github-actions bot requested review from eriktate and vapopov October 8, 2025 14:54
@smallinsky smallinsky added the no-changelog Indicates that a PR does not require a changelog entry label Oct 8, 2025
@smallinsky smallinsky force-pushed the smallinsky/fix-setting-default-eligibility branch from 2777b80 to 4b3e479 Compare October 9, 2025 11:26
@smallinsky
Copy link
Contributor Author

Friendly ping @eriktate @vapopov

@smallinsky smallinsky added this pull request to the merge queue Oct 15, 2025
Merged via the queue into master with commit dad7dc2 Oct 15, 2025
40 checks passed
@smallinsky smallinsky deleted the smallinsky/fix-setting-default-eligibility branch October 15, 2025 12:05
@backport-bot-workflows
Copy link
Contributor

@smallinsky See the table below for backport results.

Branch Result
branch/v17 Failed
branch/v18 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v17 backport/branch/v18 no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants