feat: IAM method support in new join service #60033
Open
+883
−518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
no-changelog
nklaassen
commented
Oct 8, 2025
| // To keep this validation simple and secure, we check the given endpoint | ||
| // against a static list of known valid endpoints. We will need to update this | ||
| // list as AWS adds new regions. | ||
| func validateSTSHost(stsHost string, fips bool) error { |
There was a problem hiding this comment.
code in this file has been moved from lib/auth/join_iam.go with minimal changes
nklaassen
commented
Oct 8, 2025
| authCtx, | ||
| boundKeypairInit.ClientParams.BotParams, | ||
| claims, | ||
| nil, // TODO(timothyb89): workload id claims |
There was a problem hiding this comment.
@timothyb89 this TODO was in the original bound keypair implementation, copied here now that one of the join methods actually has workload ID claims and it became a parameter here
There was a problem hiding this comment.
Thanks for the heads up - this one isn't urgent so I see no issues copying the comment.
bernardjkim
approved these changes
Oct 15, 2025
nklaassen
force-pushed
the
nklaassen/iam-messages
branch
from
55c0ced to
d798024
Compare
nklaassen
force-pushed
the
nklaassen/iam
branch
from
12c2d8c to
ae4f52b
Compare
nklaassen
force-pushed
the
nklaassen/iam-messages
branch
from
d798024 to
a33fe08
Compare
nklaassen
force-pushed
the
nklaassen/iam
branch
from
ae4f52b to
27e143b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of RFD 27e
This PR adds support for the IAM join method to the new join service and client. Both the new and legacy gRPC servers are updated to use common logic that verifies the request.