Skip to content

Conversation

okraport
Copy link
Contributor

@okraport okraport commented Oct 3, 2025

This commits deperecates GetWebTokens, which should be replaced by a paginated counterpart:
ListWebTokens

Towards: https://github.com/gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListWebTokens, deprecate GetWebTokens

@okraport okraport force-pushed the okraport/paginate-GetWebTokens branch 3 times, most recently from 178d9f0 to 22f3bc3 Compare October 14, 2025 11:53

// ListWebTokens returns a page of web tokens
func (a *ServerWithRoles) ListWebTokens(ctx context.Context, limit int, start string) ([]types.WebToken, string, error) {
if err := a.authorizeAction(types.KindWebToken, types.VerbList); err != nil {
Copy link
Contributor Author

@okraport okraport Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches existing behaviour of GetWebTokens

@okraport okraport force-pushed the okraport/paginate-GetWebTokens branch 2 times, most recently from cb335e5 to fac8298 Compare October 14, 2025 14:50
@okraport okraport marked this pull request as ready for review October 14, 2025 17:41
@okraport okraport requested a review from rosstimothy October 14, 2025 17:41
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from fheinecke October 14, 2025 21:16
This commits deperecates GetWebTokens, which should be replaced by a paginated counterpart:
ListWebTokens

Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListWebTokens, deprecate GetWebTokens
@okraport okraport force-pushed the okraport/paginate-GetWebTokens branch from 5a645ea to ed26e32 Compare October 15, 2025 08:25
@okraport
Copy link
Contributor Author

Squashed & rebased.

@okraport okraport enabled auto-merge October 15, 2025 08:33
@okraport okraport added this pull request to the merge queue Oct 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2025
@okraport okraport added this pull request to the merge queue Oct 15, 2025
Merged via the queue into master with commit 6e2c6e1 Oct 15, 2025
43 checks passed
@okraport okraport deleted the okraport/paginate-GetWebTokens branch October 15, 2025 10:18
@backport-bot-workflows
Copy link
Contributor

@okraport See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Failed
branch/v18 Failed

okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v18
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v18
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v17
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v17
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v17
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v18
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v18
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v17
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v17
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v18
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v16
okraport added a commit that referenced this pull request Oct 15, 2025
Backport #59895 to branch/v17
github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants