-
Notifications
You must be signed in to change notification settings - Fork 1.9k
docs: Convert text links to TileGrid for MWI configuration and deployment #59775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The PR looks fine to me, I just think the PR description is inaccurate, as it sounds like it is reorganizing content when the actual change we're making is changing how links are styled. |
Updated! Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is better, but the PR description could still be improved.
}, | ||
{ | ||
icon: <Icon name="lock" size="xl" />, | ||
to: "../../reference/machine-workload-identity/machine-id/bound-keypair/getting-started", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, looks like this link is broken? I think it needs one more ../
?
Removed from merge queue so you can address @timothyb89 's comment about the broken link |
@mmcallister See the table below for backport results.
|
For MWI guides, rather than have "deploy on..." and "access X..." links on the page, scope to a tiled approach.