Skip to content

Conversation

mmcallister
Copy link
Contributor

@mmcallister mmcallister commented Sep 30, 2025

For MWI guides, rather than have "deploy on..." and "access X..." links on the page, scope to a tiled approach.

Copy link

github-actions bot commented Sep 30, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
mwi_tiles 6d6b776 25 ✅SUCCEED mwi-tiles 2025-10-14 17:51:20

@zmb3
Copy link
Collaborator

zmb3 commented Oct 14, 2025

The PR looks fine to me, I just think the PR description is inaccurate, as it sounds like it is reorganizing content when the actual change we're making is changing how links are styled.

@mmcallister mmcallister changed the title docs: drafting tiled approach for mwi configurations and deployments docs: Convert text links to TileGrid for MWI configuration and deployment Oct 14, 2025
@mmcallister mmcallister requested a review from zmb3 October 14, 2025 18:05
@mmcallister
Copy link
Contributor Author

The PR looks fine to me, I just think the PR description is inaccurate, as it sounds like it is reorganizing content when the actual change we're making is changing how links are styled.

Updated! Thank you

@mmcallister mmcallister marked this pull request as ready for review October 14, 2025 18:07
@mmcallister mmcallister enabled auto-merge October 14, 2025 18:07
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is better, but the PR description could still be improved.

},
{
icon: <Icon name="lock" size="xl" />,
to: "../../reference/machine-workload-identity/machine-id/bound-keypair/getting-started",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like this link is broken? I think it needs one more ../?

@mmcallister mmcallister added this pull request to the merge queue Oct 15, 2025
@strideynet strideynet removed this pull request from the merge queue due to a manual request Oct 15, 2025
@strideynet
Copy link
Contributor

Removed from merge queue so you can address @timothyb89 's comment about the broken link

@mmcallister mmcallister added this pull request to the merge queue Oct 16, 2025
Merged via the queue into master with commit 384d194 Oct 16, 2025
46 checks passed
@mmcallister mmcallister deleted the mwi_tiles branch October 16, 2025 02:05
@backport-bot-workflows
Copy link
Contributor

@mmcallister See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Failed
branch/v18 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants