Skip to content

Conversation

strideynet
Copy link
Contributor

Teleport V14 shipped with a new configuration format for Machine ID, we migrated on-the-fly from V13 to the new format, and provided tooling to persist this migration. This PR removes support for this migration starting from V17.

changelog: BREAKING: The tbot binary no longer supports the V1 configuration format that was deprecated from V14. See https://goteleport.com/docs/machine-id/reference/v17-upgrade-guide/ for more information.

@zmb3
Copy link
Collaborator

zmb3 commented Jun 28, 2024

Do we have any idea how prevalent the deprecated format is in the wild? CI/CD tends to be set and forget, so I wouldn't be surprised if this change catches people by surprise and breaks things.

@strideynet
Copy link
Contributor Author

Do we have any idea how prevalent the deprecated format is in the wild? CI/CD tends to be set and forget, so I wouldn't be surprised if this change catches people by surprise and breaks things.

@zmb3 - we don't have analytics for this - but at least in my experience, it's been at least 3 months since I've seen this in the wild. I can take a slightly less aggressive approach if you'd prefer whereby in V17, we emit a fatal error that can be ignored with an environment variable and then in v18, we finally drop this code.

I do personally feel though that if we're talking about CI/CD in particular here, there's going to be some active step on behalf of the administrator to bump the major version - if they've chosen to ignore two breaking change warnings in major release notes and a warning message on start for three versions, then their first CI run after upgrading will result in a failure, and they can roll back to V16, run the migration, and then proceed to V17. I can modify the error log here to be a little more descriptive in the steps they need to take.

Copy link
Contributor

@timothyb89 timothyb89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure when we'll want to pull the trigger on this, but it looks good to me.

@zmb3
Copy link
Collaborator

zmb3 commented Apr 18, 2025

@strideynet should we merge this for v18?

@strideynet strideynet force-pushed the strideynet/remove-deprecated-config-migration branch from e3e63cb to eafe1f2 Compare October 16, 2025 10:40
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from lxea October 16, 2025 10:41
@strideynet strideynet added this pull request to the merge queue Oct 16, 2025
Merged via the queue into master with commit ccbe527 Oct 16, 2025
42 checks passed
@strideynet strideynet deleted the strideynet/remove-deprecated-config-migration branch October 16, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants