Fix: JS grammar detects gql tags in comments
#4087
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a repro for now.
gqltags inside of comments are detected by the grammar and should probably be ignored. Anyone motivated to fix this: please feel free to push to this branch (if you're able) or pick my repro commit to another PR and close this one out.Had issues running
yarn vitestandyarn workspace vscode-graphql-syntax testso I addedvitestas a dev dependency (and matched the version the repo uses). Perhaps I'm missing the "right" way to run these tests.Also: not obvious to me why git is detecting the entire file changes, but hiding whitespace while reviewing reveals the actual diff in the snapshot correctly.