Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Remove query, variables, headers and response props in <GraphiQL />, <GraphiQLProvider /> and <EditorContextProvider /> #3735

Draft
wants to merge 3 commits into
base: graphiql-v4
Choose a base branch
from

Apply suggestions from code review

d2daab6
Select commit
Loading
Failed to load commit list.
Draft

[v4] Remove query, variables, headers and response props in <GraphiQL />, <GraphiQLProvider /> and <EditorContextProvider /> #3735

Apply suggestions from code review
d2daab6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 24, 2024 in 1s

67.21% (target 50.00%)

View this Pull Request on Codecov

67.21% (target 50.00%)

Details

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.21%. Comparing base (3a2580e) to head (d2daab6).
Report is 19 commits behind head on graphiql-v4.

Files with missing lines Patch % Lines
packages/graphiql-react/src/editor/context.tsx 63.63% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           graphiql-v4    #3735      +/-   ##
===============================================
- Coverage        67.26%   67.21%   -0.05%     
===============================================
  Files              120      120              
  Lines             7019     7018       -1     
  Branches          2268     2275       +7     
===============================================
- Hits              4721     4717       -4     
- Misses            2281     2284       +3     
  Partials            17       17              
Files with missing lines Coverage Δ
packages/graphiql-react/src/editor/hooks.ts 37.50% <ø> (-0.88%) ⬇️
packages/graphiql-react/src/provider.tsx 100.00% <ø> (ø)
packages/graphiql/src/components/GraphiQL.tsx 78.38% <ø> (ø)
packages/graphiql-react/src/editor/context.tsx 73.80% <63.63%> (-2.62%) ⬇️