fix: correct maybe deep promise typing#906
Open
shreyas44 wants to merge 5 commits intographql-nexus:mainfrom
Open
fix: correct maybe deep promise typing#906shreyas44 wants to merge 5 commits intographql-nexus:mainfrom
shreyas44 wants to merge 5 commits intographql-nexus:mainfrom
Conversation
shreyas44
changed the title
Contributor
|
Is the change in this PR causing https://github.com/graphql-nexus/nexus/pull/906/checks?check_run_id=2589178499#step:6:12? Would seem so but not sure. |
Contributor
Author
|
Yep, you're right, the change in the PR did cause the issue. It seems to stem from the fact that TypeScript distributes unions when evaluating conditional types. I fixed that and also removed a redundant |
Contributor
|
Tests still seem to be failing though? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the conditional type for null in
MaybePromiseDeepseems to fix the below linked issue without removing any type safety.I've tested it with the getters for
edgesandpageInfowith and without promises.However, I feel that conditional type was there for a reason, but I couldn't figure out why and I'm not entirely sure if this breaks something else as it seems to be a utility used in multiple places across the library.
Closes #853