Add documentation for Chained DataLoaders #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andimarek
requested changes
Jul 17, 2025
documentation/batching.md
Outdated
| ``` | ||
|
|
||
| ### How do I enable Chained DataLoaders? | ||
| As this changes execution order, you must opt-in to Chained DataLoaders by setting key-value pairs in `GraphQLContext`. |
There was a problem hiding this comment.
we actually recommend people to use the UnusualConfiguration option and not directly put stuff into the GraphQLContext. See https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/GraphQLUnusualConfiguration.java
I think we need todo a follow up PR to add this config there
There was a problem hiding this comment.
Ok will change this
A note for another PR - other documentation pages will need an update to use the central Configuration class
documentation/batching.md
Outdated
| 2. Provide a `ScheduledExecutorService` to GraphQL Java, with key `DataLoaderDispatchingContextKeys.DELAYED_DATA_LOADER_DISPATCHING_EXECUTOR_FACTORY` and value implementing `DelayedDataLoaderDispatcherExecutorFactory` | ||
|
|
||
| ### What changed in GraphQL Java 25.0? | ||
| The DataFetcher in the example above, before version 25.0 would have caused execution to hang, because the first DataLoader ("name") was never dispatched. |
There was a problem hiding this comment.
the first would dispatch, but not the second ("email")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature coming in v25.0, and is available via the preview version v25.0.beta-2
This is written taking into account feedback regarding the confusion of the batch window configuration