fix: require-selections requireAllFields false positives #2912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the
require-selections
rule with therequireAllFields
option, a selection on a type that has any of thefieldNames
is demanded to include all of thefieldNames
, whether or not they exist on that type.The issue lies in the
checkFields
function. It exits early if the type being inspected doesn't implement any of thefieldNames
configured for the rule. Otherwise, it proceeds to report on all of thefieldNames
configured for the rule, not just the ones that exist on the type.Fixes #2911
Type of change
Please delete options that are not relevant.
expected)
How Has This Been Tested?
A unit test that fails without the update to the rule has been added.
Test Environment:
@graphql-eslint/...
: 4.4.0Checklist:
CONTRIBUTING doc and the
style guidelines of this project