Skip to content

Run the persisted documents plugin before the usage reporting and registry plugin #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 25, 2025

Conversation

enisdenjo
Copy link
Member

@enisdenjo enisdenjo commented Jul 24, 2025

Ref GW-440

TODO

  • Write tests

@Copilot Copilot AI review requested due to automatic review settings July 24, 2025 10:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorders the plugin execution in the gateway runtime to ensure the persisted documents plugin runs before the registry plugin. This change ensures that queries are properly discovered by the persisted documents plugin before being reported by the usage reporting and registry functionality.

  • Reordered plugin execution sequence in the gateway runtime
  • Added a changeset documenting the plugin execution order change

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/runtime/src/createGatewayRuntime.ts Swapped the order of persistedDocumentsPlugin and registryPlugin in the plugins array
.changeset/five-pillows-turn.md Added changeset entry documenting the plugin reordering change

@enisdenjo enisdenjo marked this pull request as draft July 24, 2025 10:34
@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 24, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/gateway 1.16.1-alpha-6efe9e35d4088a69d106c2d21d4a5b1af1e90d79 npm ↗︎ unpkg ↗︎
@graphql-hive/nestjs 1.0.20-alpha-6efe9e35d4088a69d106c2d21d4a5b1af1e90d79 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-opentelemetry 1.3.64-alpha-6efe9e35d4088a69d106c2d21d4a5b1af1e90d79 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-prometheus 1.3.52-alpha-6efe9e35d4088a69d106c2d21d4a5b1af1e90d79 npm ↗︎ unpkg ↗︎
@graphql-hive/gateway-runtime 1.10.1-alpha-6efe9e35d4088a69d106c2d21d4a5b1af1e90d79 npm ↗︎ unpkg ↗︎

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 24, 2025

🚀 Snapshot Release (Binary for Linux-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 24, 2025

🚀 Snapshot Release (Binary for macOS-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 24, 2025

🚀 Snapshot Release (Binary for Linux-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 24, 2025

🚀 Snapshot Release (Binary for Windows-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 24, 2025

🚀 Snapshot Release (Binary for macOS-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 24, 2025

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.16.1-alpha-6efe9e35d4088a69d106c2d21d4a5b1af1e90d79-bun

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 24, 2025

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.16.1-alpha-6efe9e35d4088a69d106c2d21d4a5b1af1e90d79

@enisdenjo enisdenjo marked this pull request as ready for review July 24, 2025 12:23
@enisdenjo enisdenjo requested a review from ardatan July 24, 2025 12:23
@enisdenjo enisdenjo merged commit 352e89d into main Jul 25, 2025
67 checks passed
@enisdenjo enisdenjo deleted the pers-ops-then-reg branch July 25, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants