fix(opentelemetry): Patch otel sdk for span start time with nanosecond precision #1343
Conversation
…ond span start time
EmrysMyrddin
force-pushed
the
fix/otel/start-time-precision
branch
from
afafe0e to
e42ccc8
Compare
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-tools/batch-delegate |
10.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/batch-execute |
10.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/delegate |
11.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/executor-common |
1.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/executor-graphql-ws |
3.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/executor-http |
3.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/federation |
4.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/fusion-runtime |
1.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/importer |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/logger |
1.0.1-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/nestjs |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-aws-sigv4 |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-deduplicate-request |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/hmac-upstream-signature |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-jwt-auth |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-opentelemetry |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-prometheus |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/pubsub |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway-runtime |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/signal |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/stitch |
10.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/stitching-directives |
4.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/transport-common |
1.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/transport-http |
1.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/transport-http-callback |
1.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/transport-ws |
2.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/wrap |
11.0.0-alpha-5e6098404239267121abde7700e66aca66ec76b1 |
npm ↗︎ unpkg ↗︎ |
| @@ -71,7 +71,7 @@ | |||
| "@opentelemetry/resources": "^2.0.1", | |||
| "@opentelemetry/sdk-logs": "^0.203.0", | |||
| "@opentelemetry/sdk-node": "^0.203.0", | |||
| "@opentelemetry/sdk-trace-base": "^2.0.1", | |||
| "@opentelemetry/sdk-trace-base": "patch:@opentelemetry/sdk-trace-base@patch%3A@opentelemetry/sdk-trace-base@npm%253A2.0.1%23~/.yarn/patches/@opentelemetry-sdk-trace-base-npm-2.0.1-ebe4f8e34e.patch%3A%3Aversion=2.0.1&hash=212481#~/.yarn/patches/@opentelemetry-sdk-trace-base-patch-0b7dbf6a30.patch", | |||
There was a problem hiding this comment.
Publishing this will break installs. Patches are only for local things. If patching the library is the only way to go, then we need to handle it differently - on Hive Console side.
P.S. Node has only millisecond precision, so we cannot expect it to give out accurate nanoseconds.
There was a problem hiding this comment.
Oh yes, I should only add this to the root package.json.
It's more an experiment at this point for @n1ru4l
We can ship this in the binary, but not sure we should have such behavior diff between binary and node usage.
I'm trying to make a PR on opentelemetry side. Perhaps I can publish a fork ?
There was a problem hiding this comment.
I think pushing this PR to OTEL is a good way to go. But we dont have to do all that just for one change, do you think they'd release soon or would it take months?
There was a problem hiding this comment.
Based on other PR dates, it takes loooong time to merge things, even for member of the repo...
There was a problem hiding this comment.
And we cannot handle it in Hive Console @n1ru4l? I can imagine others using Hive Console's observability features having the same issues, especially if based on OTEL's libs.
There was a problem hiding this comment.
It can't be on Hive Console side, since it's the data producer that has the "bug".
It's span creation that uses a low precision timestamp...
A workaround for us waiting for a proper upstream fix would be to manually provide the start and end times. This way, we are sure that at least our spans have correct precision.
🚀 Snapshot Release (Binary for
|
🚀 Snapshot Release (Binary for
|
🚀 Snapshot Release (Binary for
|
🚀 Snapshot Release (Binary for
|
🚀 Snapshot Release (Bun Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
🚀 Snapshot Release (Binary for
|
🚀 Snapshot Release (Node Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
Related: open-telemetry/opentelemetry-js#5804