SQL query interface (very experimental) #6172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isum
requested changes
Oct 7, 2025
|
Addressed all review comments |
isum
approved these changes
Oct 29, 2025
1. Do not use CTE's to inject a view of a table at a certain block. Instead rewrite the 'from' clause 2. Do not turn bytea columns into string columns since that is hugely wasteful
That setup makes it much easier to add more tests that check that we scrub dangerous constructs from SQL
The wrapping with to_jsonb is closely tied to how we run the query
This is to keep Postgres from complaining about reserved words as column names, e.g., the column `to` needs to appear as `"to"` in a query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up the work done in PR #5382. Its main purpose is to help evaluate how such an interface would work. There's no expectation that this will ever make it into a graph-node release at this point.
Documentation can be found in docs/implementation/sql-interface.md in this PR
This is a continuation of PR #5799 but had to be a new PR because of commit signing