Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup TAPCollectorAuthorizationAlreadyRevoked #1089

Open
wants to merge 1 commit into
base: horizon
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/horizon/contracts/interfaces/ITAPCollector.sol
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,10 @@ interface ITAPCollector is IPaymentsCollector {
error TAPCollectorSignerNotAuthorizedByPayer(address payer, address signer);

/**
* Thrown when the attempting to revoke a signer that was already revoked
* Thrown when attempting to thaw a signer that is already revoked
* @param signer The address of the signer
*/
error TAPCollectorAuthorizationAlreadyRevoked(address payer, address signer);
error TAPCollectorAuthorizationAlreadyRevoked(address signer);

/**
* Thrown when attempting to thaw a signer that is already thawing
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ contract TAPCollector is EIP712, GraphDirectory, ITAPCollector {
PayerAuthorization storage authorization = authorizedSigners[signer];

require(authorization.payer == msg.sender, TAPCollectorSignerNotAuthorizedByPayer(msg.sender, signer));
require(!authorization.revoked, TAPCollectorAuthorizationAlreadyRevoked(msg.sender, signer));
require(!authorization.revoked, TAPCollectorAuthorizationAlreadyRevoked(signer));
require(
authorization.thawEndTimestamp == 0,
TAPCollectorSignerAlreadyThawing(signer, authorization.thawEndTimestamp)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ contract TAPCollectorThawSignerTest is TAPCollectorTest {

bytes memory expectedError = abi.encodeWithSelector(
ITAPCollector.TAPCollectorAuthorizationAlreadyRevoked.selector,
users.gateway,
signer
);
vm.expectRevert(expectedError);
Expand Down
Loading