-
Notifications
You must be signed in to change notification settings - Fork 164
TRST audit fixes for Graph Payments contracts #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da0427a to
65e99f9
Compare
TRST audit fixes for Graph Payments contracts
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
…H01) Signed-off-by: Tomás Migone <[email protected]>
d705ca6 to
7d62913
Compare
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
…(TRST-L10) Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
7d62913 to
670fba7
Compare
…R03) Signed-off-by: Tomás Migone <[email protected]>
Maikol
approved these changes
Dec 6, 2024
Maikol
approved these changes
Dec 10, 2024
Member
Maikol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
packages/horizon/test/payments/tap-collector/collect/collect.t.sol
Outdated
Show resolved
Hide resolved
packages/subgraph-service/test/subgraphService/collect/query/query.t.sol
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomás Migone <[email protected]>
89567c8 to
a065804
Compare
Maikol
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following audit findings:
TRST-H-1 A payer could bypass the escrow mechanism and avoid paymentsTRST-M-10 A RAV could be collected more than once, leading to double paymentTRST-CL-1 A payer could bypass the escrow mechanism and avoid payments through the vulnerable collector allowance mappingTTRST-L-10 The getBalance() function could revert when balance is lower than tokens thawingTRST-M-5 Lack of chunking functionality of new RAVs may cause them to not be processableTRST-L-12 The collection cuts could exceed 100% causing collect() to revert