Skip to content

Render system refactor #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

Render system refactor #73

wants to merge 59 commits into from
+2,995 −1,751

Conversation

@mmmhj2
Copy link
Member

@mmmhj2 mmmhj2 commented Nov 29, 2025

A small refactor of the render system that grows into some new features:

  • Support for lighting. Both shadow casting lights with shadowmaps and non casting lights are supported. Components for lights are to be discussed.
  • Support for skybox and cubemap in general. HDRi support is planned but depends on the asset loader.

Minor refactors:

  • Initialization of Vulkan removed from RenderSystem.
  • Show message box for unrecoverable errors.
  • Remove constant classes and Vukan wrappers.
  • Aggregate global data management.
  • Fix and update on documentations.

mmmhj2 added 30 commits November 17, 2025 20:40
@mmmhj2
Aggregate Vulkan initialization
2814b94
@mmmhj2
Remove instance and physical device
04a2763
@mmmhj2
Remove device init code from RenderSystem
a29cf83
@mmmhj2
Terminate on failed swapchain creation
3d22893
@mmmhj2
Remove m_system from SlicedTextureView
023514e
@mmmhj2
Remove m_system from GUISystem
ae50491
@mmmhj2
Remove image views in Swapchain.
7d45d52 
We don't render to swapchain images, so no image views are needed.
@mmmhj2
Use separate descriptor set pool for ImGui
aa89081
@mmmhj2
Fix GUI descriptor pool not properly destory
46d04dd
@mmmhj2
Adjust Vulkan loader init location
fdf3f56
@mmmhj2
Match up SDL_LogCritical with error boxes
987ad23
@mmmhj2
Reduce Vulkan low-level exposure
8ee51f8
@mmmhj2
Provide interface for physical device limit queries
582702d
@mmmhj2
Remove RenderSystem reference from buffers and textures
465e1d6
@mmmhj2
Remove RenderSystem from command buffers
b30420d
@mmmhj2
Remove VkWrapper.tcc
bc95e89
@mmmhj2
Add Camera Manager class
35d895e
@mmmhj2
Adjust interface of RenderSystem
cb5da82
@mmmhj2
Remove CameraConstants classes
8f800d0
@mmmhj2
Add camera_index to push constants
88658da
@mmmhj2
Resolve compilation problems
61a8f11
@mmmhj2
Update shaders
ce41266
@mmmhj2
Fix some validation layer problem
6a0badb
@mmmhj2
Add camera matrix update logic
eb31bb5
@mmmhj2
Work around camera register problem
57176ca
@mmmhj2
Fix wrong load operation of GUI pass
6022a40
@mmmhj2
Use dedicated descriptor pool for camera
af8cbe4
@mmmhj2
Add SceneDataManager
37ddc05
@mmmhj2
Remove remaining constant classes
80fb302
@mmmhj2
Resolve compilation problems
90de99d 
Compute pipeline descriptors are now allocated in a dedicated pool.
mmmhj2 added 26 commits November 25, 2025 02:30
@mmmhj2
Address GLM clip space problem
95034ef
@mmmhj2
Remove vulkan inclusion in VertexStruct.h
7bf2fa2
@mmmhj2
Unify test apparatus
eb1aec2
@mmmhj2
Add cube.obj
681c478
@mmmhj2
Use managed renderers
e2b01eb
@mmmhj2
Add cube and sphere meshes in shadow map test
f6d1286
@mmmhj2
Update SceneDataManager interface
f71578f
@mmmhj2
Add shadow map support
7759c55
@mmmhj2
Replace eShaderReadOnlyOptimal
12298ef
@mmmhj2
Update shadowmap test
9b9153b
@mmmhj2
Add skybox cubemap
bcd0023
@mmmhj2
Add cubemap asset
b39e2a9
@mmmhj2
Add infrastructure support for cubemaps
ea5fc83
@mmmhj2
Add new test on skybox
a14aec3
@mmmhj2
Fix zero descriptor written
c0c88b7
@mmmhj2
Force cubemap to have 4 channels
269d93b 
R8G8B8Srgb format is poorly supported, and if we want to use B8G8R8Srgb then we will have to manually swizzle them as stbi does not support it.
@mmmhj2
Disable stbi flip.
726a7a7
@mmmhj2
Reorganize SceneDataManager interface
bc066b2
@mmmhj2
Add skybox pipeline creation code
7f63dae
@mmmhj2
Setup test for skybox.
8b7a862
@mmmhj2
Fix skybox not appearing
12f0695
@mmmhj2
Update coordinate system doc
c68e13c
@mmmhj2
Fix skybox not shown correctly
15596a7
@mmmhj2
Add non casting light support
17a3107
@mmmhj2
Fix missing shadowmap error in tests
576cc24
@mmmhj2
Suppress error in shader reflection test
d2d1899
@mmmhj2 mmmhj2 self-assigned this Nov 29, 2025
@mmmhj2 mmmhj2 added the enhancement New feature or request label Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaptainHarryChen CaptainHarryChen Awaiting requested review from CaptainHarryChen

At least 1 approving review is required to merge this pull request.

Assignees

@mmmhj2 mmmhj2

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmmhj2