Prevent exit codes > 255 in convert.py #1233
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
colmap
executable can return exit codes greater than 255. In the special case of 256, which for example happens on a bad input paththis seems to overflow to 0, making scripted tools think the invocation succeeded. Considering behavior of POSIX exit codes that are outside of the range between 0 and 255 seems to be undefined, it probably makes sense to just exit 1 on anything above 255. The exit code returned by invoking colmap will still be printed for debugging.