Runtime configurable BLS crate - attempt 2#182
Draft
ArtiomTr wants to merge 1 commit intograndinetech:developfrom
Draft
Runtime configurable BLS crate - attempt 2#182ArtiomTr wants to merge 1 commit intograndinetech:developfrom
ArtiomTr wants to merge 1 commit intograndinetech:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is second attempt to create runtime configurable BLS crate (#181). Here backend is specified via global variable, so no need to specify backend when implementing traits like
DefaultorTryFrom. However, bls backend must be set beforehand, otherwise setting other bls backend can mix backends, and panic. I can avoid panicking, by doing backward conversion - e.g., if somehowPublicKey::Blstwas initialized, butPublicKey::Zkcryptois needed, I can convertPublicKey::Blst->PublicKeyBytes->PublicKey::Zkcrypto. Such approach will never panic, but will have performance penalty for converting between backends.