feat(stdlib): Optimize List.init
to support large lists
#2249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr optimizes
List.init
to support large allocations without overflowing the call stack.On lists smaller than
2500
we use the old approach and for anything else we use a tco approach build the list and then reverse it.Notes
2500
is a rather arbitrary choice to switch over, We start having stack overflows with the grain runner around 5k elements and I figured other runtimes might have smaller stacks so it probably makes sense to switch over before that.List.reverse
overhead==
for lists #2247 needs to be merged before this for tests to pass.