Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(stdlib): Simplify Float32.Infinity and Float32.NaN definitions #1955

Merged
merged 1 commit into from
Jan 25, 2024
Merged

chore(stdlib): Simplify Float32.Infinity and Float32.NaN definitions #1955

merged 1 commit into from
Jan 25, 2024

Conversation

spotandjake
Copy link
Member

@spotandjake spotandjake commented Jan 2, 2024 •
edited
Loading

Repurposed this pr to remove Float32.Infinity and Float32.NaN in favour of the Infinityf and NaNf syntax

@spotandjake spotandjake self-assigned this Jan 2, 2024
phated
phated requested changes Jan 7, 2024
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we just remove these or do we like Float32.infinity instead of Infinityf?

@spotandjake spotandjake force-pushed the spotandjake-float32-inf branch from fcab61a to ae788c9 Compare January 8, 2024 20:00
@spotandjake spotandjake changed the title chore(stdlib): Simplify Float32.Infinity, Float32.NaN definitions chore(stdlib)!: Remove Float32.Infinity and Float32.NaN Jan 8, 2024
@spotandjake spotandjake force-pushed the spotandjake-float32-inf branch from ae788c9 to fc1c160 Compare January 22, 2024 17:26
@spotandjake spotandjake force-pushed the spotandjake-float32-inf branch from fc1c160 to 06ad96f Compare January 22, 2024 17:26
@spotandjake spotandjake changed the title chore(stdlib)!: Remove Float32.Infinity and Float32.NaN chore(stdlib): Simplify Float32.Infinity and Float32.NaN definitions Jan 22, 2024
@phated phated added this pull request to the merge queue Jan 25, 2024
Merged via the queue into grain-lang:main with commit a963d8f Jan 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@ospencer ospencer Awaiting requested review from ospencer ospencer is a code owner

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

Assignees

@spotandjake spotandjake

Labels
cleanup stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spotandjake @phated @ospencer