Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): Use data segments for string data #1330

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(compiler): Use data segments for string data #1330

wants to merge 1 commit into from

Conversation

ospencer
Copy link
Member

No description provided.

@ospencer ospencer self-assigned this Jun 13, 2022
@peblair peblair mentioned this pull request Jun 18, 2022
Open
@phated phated added the blocked label Jan 22, 2023
@phated phated removed the blocked label Apr 27, 2023
@ospencer ospencer force-pushed the oscar/data-segments branch from d6820a9 to bbdd61c Compare April 27, 2023 16:29
@ospencer ospencer mentioned this pull request May 11, 2023
Closed
@ospencer ospencer force-pushed the oscar/data-segments branch from 6e68d1b to 032d567 Compare January 30, 2024 23:33
@ospencer ospencer mentioned this pull request Jan 30, 2024
Closed
@ospencer ospencer marked this pull request as ready for review January 30, 2024 23:43
spotandjake
spotandjake approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how much cleaner the outputted code is with this change.

@phated phated added the blocked label Feb 29, 2024
@spotandjake
Copy link
Member

I am pretty sure this was unblocked with #2104 as we no longer lose the debug information when linking.

@ospencer ospencer force-pushed the oscar/data-segments branch from cf70d3b to 68b9ed5 Compare January 17, 2025 04:18
@ospencer ospencer force-pushed the oscar/data-segments branch 2 times, most recently from e90cc27 to 15a2620 Compare January 17, 2025 04:23
@ospencer ospencer removed the blocked label Jan 17, 2025
@ospencer
Copy link
Member Author

Rebased this. Looks like it's largely working with one test failure that needs to be looked into. I also don't like how the data segments are handled; they're lumped in with the type metadata. That'll need to be cleaned up.

@ospencer ospencer force-pushed the oscar/data-segments branch from 15a2620 to 8c062af Compare February 16, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spotandjake spotandjake spotandjake approved these changes

@phated phated Awaiting requested review from phated phated is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

@alex-snezhko alex-snezhko Awaiting requested review from alex-snezhko alex-snezhko is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ospencer @spotandjake @phated