fix(grainfmt): Correct formatting of nested constraints (#2245)

grain-lang · Feb 16, 2025 · bdb7f7c · bdb7f7c
1 parent 2f16ba5
commit bdb7f7c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/compiler/src/formatting/fmt.re b/compiler/src/formatting/fmt.re
@@ -258,6 +258,13 @@ let needs_grouping = (~parent, ~side: infix_side, expr) => {
   | (PExpConstant(PConstNumber(PConstNumberRational(_))), _)
       when op_precedence('/') <= precedence(parent) =>
     ParenGrouping
+  | (PExpConstraint(_, _), _)
+      when
+        switch (parent.pexp_desc) {
+        | PExpConstraint(_, _) => true
+        | _ => false
+        } =>
+    ParenGrouping
   | _ => FormatterGrouping
   };
 };

diff --git a/compiler/test/grainfmt/constraints.expected.gr b/compiler/test/grainfmt/constraints.expected.gr
@@ -8,3 +8,8 @@ let test = test => {
     print(i)
   }, test: List<Number>)
 }
+
+// Regression #2244
+(1: Number): Number
+
+((1: Number): Number): Number
diff --git a/compiler/test/grainfmt/constraints.input.gr b/compiler/test/grainfmt/constraints.input.gr
@@ -8,3 +8,8 @@ let test = test => {
     print(i)
   }, test: List<Number>)
 }
+
+// Regression #2244
+(1: Number): Number
+
+((1: Number): Number): Number