Skip to content

Commit

Permalink
fix(runtime): Correct Bi.toFloat64 rounding (#2160)
Browse files Browse the repository at this point in the history
  • Loading branch information
spotandjake authored Sep 19, 2024
1 parent 6c33d08 commit 6755782
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
13 changes: 13 additions & 0 deletions compiler/test/stdlib/float64.test.gr
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,19 @@ assert e == 2.718281828459045d
let fromNumber = fromNumber
assert fromNumber(5) == 5.0d
assert fromNumber(0) == 0.0d
assert fromNumber(0.5) == 0.5d
assert fromNumber(1/2) == 0.5d
assert fromNumber(-1/2) == -0.5d
// Not exact because of ieee754 rounding error
assert fromNumber(18_446_744_073_709_551_615) == 18_446_744_073_709_552_000.0d
assert fromNumber(18_446_744_073_709_551_616) == 18_446_744_073_709_552_000.0d
assert fromNumber(18_446_744_073_709_551_616) == 18_446_744_073_709_551_616.0d
assert fromNumber(-18_446_744_073_709_551_615) == -18446744073709552000.0d
assert fromNumber(-18_446_744_073_709_551_616) == -18446744073709552000.0d
assert fromNumber(-18_446_744_073_709_551_616) == -18_446_744_073_709_551_616.0d
// overflow
assert fromNumber(1.7976931348623157e+309) == Infinityd
assert fromNumber(-1.7976931348623157e+309) == -Infinityd

assert toNumber(555.0d) == 555
assert toNumber(0.0d) == 0
Expand Down
5 changes: 1 addition & 4 deletions stdlib/runtime/bigint.gr
Original file line number Diff line number Diff line change
Expand Up @@ -521,11 +521,8 @@ provide let toFloat64 = (num: WasmI32) => {
let mut result = 0.0W
use WasmI32.{ (+) }
for (let mut i = 0n; WasmI32.ltU(i, numLimbs); i += 1n) {
if (!WasmI32.eqz(i)) {
result *= factor
}
use WasmF64.{ (+) }
result += WasmF64.convertI64U(getLimb(num, i))
result += WasmF64.convertI64U(getLimb(num, i)) * factor
}
result
}
Expand Down

0 comments on commit 6755782

Please sign in to comment.