fix(v2): make segment upload hedging limiter respect context #4252
+144
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alsoba13 |
kolesnikovae
force-pushed
the
fix/segment-upload-hedge-limiter
branch
from
7501da7 to
1cf9d17
Compare
|
Sorry for the delay. LGTM |
alsoba13
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the segment writer failed to upload to object storage, it could hit the hedge request rate limit and block clients ignoring the upload timeout context. This could lead to unbounded memory usage and potential OOM if object storage became unavailable. This change ensures the limiter respects the upload context.