fix: initialize phlaredb instance on query#4151
Merged
simonswine merged 1 commit intomainfrom Apr 29, 2025
Merged
Conversation
simonswine
pushed a commit
that referenced
this pull request
Apr 29, 2025
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Apr 30, 2025
This builds on top of grafana#4151 and grafana#4144, as previously initilised heads already created a folder on all ingesters. Hence the check is not detecting that there are actually no local blocks to be considered.
simonswine
added a commit
that referenced
this pull request
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4144 has introduced a bug where queries may ignore local data altogether as they wouldn't initialize the phlaredb instance and wouldn't sync metadata from the disk, if there were no pushes.