Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add check for generated files drift #3842

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

marcsanmi
Copy link
Contributor

This PR adds a new job check-generated to verify that all generated files (documentation, protobuf, etc.) are up to date with their sources. This helps prevent situations where generated files drift from their sources.

Also, bumping workflows checkout action.

@marcsanmi marcsanmi requested a review from simonswine January 14, 2025 19:19
@marcsanmi marcsanmi requested review from a team as code owners January 14, 2025 19:19
Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for adding this check ❤️

@marcsanmi marcsanmi merged commit 9d77ec6 into main Jan 15, 2025
19 checks passed
@marcsanmi marcsanmi deleted the marcsanmi/add-make-generate-ci-check branch January 15, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants