Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate metrics path to /metrics #5085

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ We prepared multiple environments:

scrape_configs:
- job_name: prometheus
metrics_path: /metrics/
metrics_path: /metrics
authorization:
credentials: my_random_prometheus_secret
static_configs:
Expand Down
2 changes: 1 addition & 1 deletion dev/helm-local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ prometheus:
scrape_interval: 10s
extraScrapeConfigs: |
- job_name: 'oncall-exporter'
metrics_path: /metrics/
metrics_path: /metrics
static_configs:
- targets:
- oncall-dev-engine.default.svc.cluster.local:8080
4 changes: 2 additions & 2 deletions engine/apps/metrics_exporter/urls.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from django.urls import path
from django.urls import re_path

from .views import MetricsExporterView

urlpatterns = [
path("", MetricsExporterView.as_view(), name="metrics-exporter"),
re_path(r"^/?$", MetricsExporterView.as_view(), name="metrics-exporter"),
]
2 changes: 1 addition & 1 deletion engine/engine/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@

if settings.FEATURE_PROMETHEUS_EXPORTER_ENABLED:
urlpatterns += [
path("metrics/", include("apps.metrics_exporter.urls")),
path("metrics", include("apps.metrics_exporter.urls")),
]

if settings.FEATURE_TELEGRAM_INTEGRATION_ENABLED:
Expand Down
2 changes: 1 addition & 1 deletion helm/oncall/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ prometheus:
enabled: false
# extraScrapeConfigs: |
# - job_name: 'oncall-exporter'
# metrics_path: /metrics/
# metrics_path: /metrics
# static_configs:
# - targets:
# - oncall-dev-engine.default.svc.cluster.local:8080