Skip to content

Move consts package to internal as preparations for v1.0.0 #4678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Move consts package to internal as preparations for v1.0.0 #4678

merged 1 commit into from
Apr 10, 2025

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Apr 8, 2025

What?

Move consts package under internal

Why?

Reduce public API.

This was previously skipped due to extension using parts of it, but that was resolved in #4562 and #4537

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@mstoykov mstoykov added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Apr 8, 2025
@mstoykov mstoykov added this to the v1.0.0 milestone Apr 8, 2025
@mstoykov mstoykov requested a review from a team as a code owner April 8, 2025 15:10
@mstoykov mstoykov requested review from inancgumus and oleiade and removed request for a team April 8, 2025 15:10
@mstoykov mstoykov merged commit da32427 into master Apr 10, 2025
27 of 28 checks passed
@mstoykov mstoykov deleted the moveConstsPackage branch April 10, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

@oleiade oleiade oleiade approved these changes

Assignees
No one assigned
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @inancgumus @oleiade