Update Pyroscope and Tempo instrumentation library versions #1929
+98
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewslotin
added
the
Area: OSS Content
andrewslotin
requested review from
inancgumus and
joanlopez
and removed request for
a team
|
@heitortsergent, the build is failing because new versions are not released yet. This PR should be merged only after grafana/jslib.k6.io#154 is deployed. |
|
@andrewslotin what do you think of adding a variable for the library versions, so we can just update it in one place whenever we need to? We're doing this for the |
|
@heitortsergent I think this is a good idea! |
|
@andrewslotin do you want me to make the changes and commit to this PR? 🤓 |
inancgumus
approved these changes
Apr 18, 2025
joanlopez
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until grafana/jslib.k6.io#154 is deployed.
What?
Updated Tempo and Pyroscope instrumentation examples to use the latest versions of both libraries.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/k6/nextfolder of the documentation.docs/sources/k6/v{most_recent_release}folder of the documentation.Related PR(s)/Issue(s)
Implementation PR: grafana/jslib.k6.io#154