Migrate from DatasourceAPI to DatasourceWithBackend #2123
Conversation
|
Levitate is-compatible report: 🔍 Resolving @grafana/data@latest... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... 🔬 Checking compatibility between ./src/module.ts and @grafana/[email protected]... ✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/schema,@grafana/e2e-selectors,@grafana/experimental |
| const [interpolatedQuery, setInterpolatedQuery] = useState<ZabbixMetricsQuery>(query); | ||
| useEffect(() => { | ||
| const replacedQuery = datasource.interpolateVariablesInQueries([query], {})[0]; | ||
| setInterpolatedQuery(replacedQuery); | ||
| }, [query]); |
There was a problem hiding this comment.
I didn't know why we need to interpolate the query in here just yet, but I see this in some other places too. As this is being repeated I think it's good idea to create a custom hook to handle this. What do you think?
This PR migrates the use of
DatasourceApitoDatasourceWithBackend, with this a couple additional improvements were made:interpolateVariablesInQueryeverywhere instead of the customreplaceTemplateVariableswe were usingdatasource.tsand into the existingutils.tsSelectand usesComboBoxinstead.Now we can see the
querycalls being made to the backend:Tested:
ComboBoxwas working as expectedNext:
Once this is merged, we will next be able to slowly move away from using the
ZabbixConnectorto make backend datasource calls.Fixes: #131