Httptrace #1087
Httptrace #1087
Conversation
| logger := backend.Logger.FromContext(ctx) | ||
| trace := &httptrace.ClientTrace{ | ||
| GetConn: func(hostPort string) { | ||
| logger.Debug("HTTPTrace event", "event_name", "GetConn") |
There was a problem hiding this comment.
I am wondering if all of these should be level trace because for data source services, we have debug level logging turned on. This would produce a lot of logs that are only sometimes needed. So we could turn it on in that case.
We have trace log level: https://github.com/grafana/grafana-plugin-sdk-go/blob/main/backend/log/log.go#L14, but we are missing logger.Trace() method - all other levels have it.
There was a problem hiding this comment.
I'm with Ivana here. Why not just even be a trace instead of log?
There was a problem hiding this comment.
Yea.. Happy to change to Trace ( but we need to make sure the changes done in SDK first )
There was a problem hiding this comment.
BTW, Any thoughts on making it to debug but only calling this method on healthcheck rather query. Won't that solve the problems we disucussed here. :)
There was a problem hiding this comment.
I was thinking about a proper trace so these would be spans instead of logs. Like in here https://github.com/AdamKorcz/skipper/blob/d0b249a4aa8993a050b87cecc11cc6ca839195a4/proxy/proxy.go#L1464
There was a problem hiding this comment.
yea.. that too possible too.
I am thinking of deferring this to 3.0.0-beta.2
This is nice to have PR and allow us investigate any connection issues. More details about HTTP trace can be found in https://pkg.go.dev/net/http/httptrace
To debug connection issues such as DNS lookup, adding the HTTPTrace event debug logging.
How to test
git checkout httptraceyarn && yarn build && mage -v && docker compose -f ./docker-compose-debug.yaml up