refactor: move generated files to seperate directory #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-bauer
approved these changes
Dec 26, 2024
Duologic
force-pushed
the
duologic/move_generated_files
branch
from
7b3774e to
97bbcd5
Compare
Duologic
force-pushed
the
duologic/move_generated_files
branch
from
b6ecb1f to
b6ae5b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grafanaplane/had a mixture of generated files and a few non-generated files, while writing the CONTRIBUTING doc I found it hard to explain that. This PR moves the generated files one directory deeper ingrafanaplane/zz/to make that more clear.Currently most of the non-generated functions reside in
grafanaplane/main.libsonnetbut that'll quickly become hard to maintain as ownership over different parts may change hands, the file is already at 450+ LoC.