Forward connect_timeout from ToolServer to MCPClient#2
Merged
Conversation
ToolServer accepted a connect_timeout parameter but never passed it to MCPClient, which has its own default of 10s. Users configuring a longer timeout for slow-starting MCP servers would silently get the MCPClient default instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolServeraccepted aconnect_timeoutparameter and stored it asself.connect_timeout, but never passed it toMCPClientwhen creating instances in_get_mcp_client. Users configuring a longer timeout for slow-starting MCP servers would silently get MCPClient's default (10s) instead.Fix
Pass
connect_timeout=self.connect_timeoutto theMCPClientconstructor in_get_mcp_client.