[codex] fix component load event target#13360
Draft
thomwolf wants to merge 1 commit intogradio-app:mainfrom
Draft
[codex] fix component load event target#13360thomwolf wants to merge 1 commit intogradio-app:mainfrom
thomwolf wants to merge 1 commit intogradio-app:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadevent instead of serializing a null targetRoot cause
BlocksConfig.attach_load_events()was passingno_target=not has_targetfor component-attached startup load events, producingtargets=[(None, "load")]. The null-target load dependency can freeze the frontend renderer in Gradio 6.x for apps with a nonempty Dataframe and empty Row/Column layout;demo.loaduses(0, "load")and does not freeze.Fixes #13359
Validation
sfw uv run --with pytest --with pytest-asyncio python -m pytest test/test_blocks.py::TestComponentsInBlocks::test_component_load_events_target_root test/test_blocks.py::TestComponentsInBlocks::test_slider_random_value_config test/test_blocks.py::TestComponentsInBlocks::test_io_components_attach_load_events_when_value_is_fn test/test_blocks.py::TestComponentsInBlocks::test_get_load_events -qgit diff --checkLOGIN_KIND=login /tmp/check_min_login_dataframe.sh 7998 1 false false false false true 0 false false true/tmp/check_gaia_variant.sh 7996