-
Notifications
You must be signed in to change notification settings - Fork 74
Avoid Adding Duplicated JUnit Entries on Classpath #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
90d0b96
to
095a84d
Compare
I am a bit confused by this issue. IMO, the version of JUnit declared by users should take precedence. This means that whatever JUnit version we need should only be needed at compile time of native build tools, not runtime. So it's probably a dependency scope mistake ( |
095a84d
to
b841baa
Compare
d455439
to
d80a948
Compare
99c40a9
to
3f0fb62
Compare
@sbrannen @sdeleuze We need your inputs in order to accept or reject this PR. In order to fix this issue, we had to make several changes to dependencies. In particular, the junit platform native project is now compiled against one version of JUnit (whatever NBT wants to use), but will not "leak" these dependencies to consumers, so that they can use whatever version of JUnit they prefer (which may be a downgrade). While this works, this is a breaking change, because now consumers have to add the Second, and more problematic, our code depends on Junit Platform legacy reporting. I have no idea why this code is here, because our tests seem to show that it works well without. Therefore, what we've done is simply catch the error at runtime, and avoid failing if Any ideas? |
Let's discuss that in our next meeting. |
Fix for: #305