Skip to content

Commit

Permalink
Incorporate reviewer feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
fniephaus committed Oct 7, 2024
1 parent 1424a6d commit 8314da7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion graalpy/graalpy-micronaut-pygal-charts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,7 @@ The `DemoController` uses four services that all render the same XY chart using

The `DemoTest` ensures that all four service implementations render the same XY chart. Run it with `./mvnw test`.

> Note: This demo uses a single [`GraalPyContext`](src/main/java/com/example/GraalPyContext.java), which can be accessed from only one thread at a time to evaluate Python code. Pure Python packages including Pygal can be used in multiple GraalPy contexts, for example one context per thread, to improve the throughput of the application. Other demos illustrate how to pool multiple contexts.
> Note: This demo uses a single [`GraalPyContext`](src/main/java/com/example/GraalPyContext.java), which can execute [Python code in only one thread at a time](https://docs.python.org/3/glossary.html#term-global-interpreter-lock).
> Threads running Python code are internally scheduled in round-robin fashion.
> Pure Python packages including Pygal can be used in multiple GraalPy contexts, for example one context per thread, to improve the throughput of the application.
> Other demos such as [`graalwasm-micronaut-photon`](../graalwasm/graalwasm/graalwasm-micronaut-photon) illustrate how to pool multiple contexts.
5 changes: 4 additions & 1 deletion graalpy/graalpy-spring-boot-pygal-charts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,7 @@ The `DemoController` uses four services that all render the same XY chart using

The `DemoApplicationTests` ensures that all four service implementations render the same XY chart. Run it with `./mvnw test`.

> Note: This demo uses a single [`GraalPyContext`](src/main/java/com/example/demo/GraalPyContextConfiguration.java), which can be accessed from only one thread at a time to evaluate Python code. Pure Python packages including Pygal can be used in multiple GraalPy contexts, for example one context per thread, to improve the throughput of the application. Other demos illustrate how to pool multiple contexts.
> Note: This demo uses a single [`GraalPyContext`](src/main/java/com/example/demo/GraalPyContextConfiguration.java), which can execute [Python code in only one thread at a time](https://docs.python.org/3/glossary.html#term-global-interpreter-lock).
> Threads running Python code are internally scheduled in round-robin fashion.
> Pure Python packages including Pygal can be used in multiple GraalPy contexts, for example one context per thread, to improve the throughput of the application.
> Other demos such as [`graalwasm-micronaut-photon`](../graalwasm/graalwasm/graalwasm-spring-boot-photon) illustrate how to pool multiple contexts.

0 comments on commit 8314da7

Please sign in to comment.