CTS for subgroup_id language feature #4487
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tests for subgroup_id and num_subgroups builtins * builtin validation * uniformity validation * execution tests
alan-baker
force-pushed
the
subgroup-id
branch
from
d563832 to
9e5e7e0
Compare
jrprice
approved these changes
Oct 29, 2025
mwyrzykowski
approved these changes
Oct 29, 2025
dneto0
requested changes
Oct 29, 2025
| !t.params.use_struct, | ||
| 'missing @builtin(position) in the vertex output when the vertex output is not a struct' | ||
| ); | ||
| if (t.params.name === 'subgroup_id' || t.params.name === 'num_subgroups') { |
There was a problem hiding this comment.
Instead of skipping the test for these cases, fail the test when the builtin is one of these and the feature is not supported.
One way to do this is to extend the table to include an optional field about which language feature (if any) supports the builtin.
| if (t.params.enable_extension) { | ||
| if (t.params.name.includes('subgroups')) { | ||
| code += 'enable subgroup;\n'; | ||
| if (t.params.name.includes('subgroup')) { |
There was a problem hiding this comment.
By extending the info in the table, this code can be made more generic.
| module: t.device.createShaderModule({ | ||
| code: wgsl, | ||
| }), | ||
| entryPoint: 'main', |
There was a problem hiding this comment.
nit: the entryPoint field is optional when there's only one entry point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CTS for gpuweb/gpuweb#5416
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.