-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compat: fix float16(32)-renderable tests (validation) #4152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
approved these changes
Jan 21, 2025
src/webgpu/api/validation/render_pass/attachment_compatibility.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/render_pass/attachment_compatibility.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/api/validation/render_pass/render_pass_descriptor.spec.ts
Outdated
Show resolved
Hide resolved
greggman
approved these changes
Jan 22, 2025
src/webgpu/api/validation/render_pass/attachment_compatibility.spec.ts
Outdated
Show resolved
Hide resolved
greggman
approved these changes
Jan 22, 2025
src/webgpu/api/validation/render_pass/attachment_compatibility.spec.ts
Outdated
Show resolved
Hide resolved
Failing on core. I probably only test on compat skipping for this one... I will fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4148 fixing operation tests
This CL fixes validation tests
There are mainly 3 categories:
t.selectDeviceForRenderableColorFormatOrSkipTestCase(format);
to require float16(32)-renderable featuresmaxColorAttachmentBytesPerSample.spec.ts
): They aren't really testing float16, 32 format, they simply pick a random format to test storages, etc. Change them to another format (*uint) that still fits the needcreateBindGroup.spec.ts
, it's testing all usages: render_attachment, multisample, all 3 storage binding, there's no other format having full support of these like that of r32float.attachment_compatibility.spec.ts
): They are testing if formatA === formatB. and the params.format is subcase. Simply skip 16float and 32float on these (regardless of float16(32)renderable availability). I think it's okay given what they are testing against.