Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: fix float16(32)-renderable tests (validation) #4152

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

shrekshao
Copy link
Contributor

@shrekshao shrekshao commented Jan 21, 2025

Following #4148 fixing operation tests

This CL fixes validation tests

There are mainly 3 categories:

  • Regular ones: add t.selectDeviceForRenderableColorFormatOrSkipTestCase(format); to require float16(32)-renderable features
    • For those requiring multisample support ,simply skip those as compat doesn't guarantee multiple support for rgba16float and *32float.
  • (Example: maxColorAttachmentBytesPerSample.spec.ts): They aren't really testing float16, 32 format, they simply pick a random format to test storages, etc. Change them to another format (*uint) that still fits the need
    • Can't do that for createBindGroup.spec.ts, it's testing all usages: render_attachment, multisample, all 3 storage binding, there's no other format having full support of these like that of r32float.
  • (Example: attachment_compatibility.spec.ts): They are testing if formatA === formatB. and the params.format is subcase. Simply skip 16float and 32float on these (regardless of float16(32)renderable availability). I think it's okay given what they are testing against.

@shrekshao shrekshao requested a review from greggman January 21, 2025 22:45
@shrekshao shrekshao enabled auto-merge (squash) January 22, 2025 00:32
@shrekshao shrekshao disabled auto-merge January 22, 2025 00:37
@shrekshao shrekshao merged commit c30b7f8 into gpuweb:main Jan 22, 2025
1 check passed
@shrekshao
Copy link
Contributor Author

shrekshao commented Jan 23, 2025

https://ci.chromium.org/ui/p/chromium/builders/try/linux-dawn-rel/42000/test-results?sortby=&groupby=

--> EXPECTATION FAILED: Color format (TextureFormat::RGBA16Uint) base type (Uint) doesn't match the fragment module output type (Float).
     - While validating targets[0] framebuffer output.
     - While validating fragment state.
     - While calling [Device].CreateRenderPipeline([RenderPipelineDescriptor]).
    : 
        
        // testValue  : 32
        // actualLimit: 32
        // sampleCount: 1
        // targets:
        //   rgba16uint  (offset:  0, align: 2, size: 8)
        //   rgba32uint  (offset:  8, align: 4, size: 16)
        //   rgba16uint  (offset: 24, align: 2, size: 8)
      
        @vertex fn vs() -> @builtin(position) vec4f {
          return vec4f(0);
        }
    
        @fragment fn fs() -> @location(0) vec4f {
          return vec4f(0);
        }
      
...

AssertionError: webgpu:api,validation,capability_checks,limits,maxColorAttachmentBytesPerSample:createRenderPipeline,at_over: failed
  EXPECTATION FAILED: Color format (TextureFormat::RGBA16Uint) base type (Uint) doesn't match the fragment module output type (Float).

Failing on core. I probably only test on compat skipping for this one... I will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants