Compat: Refactor draw test for 0 storage buffers #4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored one test to only optionally use a storage buffer. Refactored another test to be skipped if no storage buffers in fragment shaders. It's possible the 2nd test is not needed as it seems similar things are tested in src/webgpu/api/operation/vertex_state/correctness.spec.ts. It's also possible the first test's case of seeing that the fragment shader is not called for certain cases is also tested elsewhere.
shrekshao
approved these changes
Jan 16, 2025
|
Yeah it is actually coverred elsewhere. If it fails, vast cts tests should have failed anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored one test to only optionally use a storage buffer. Refactored another test to be skipped if no storage buffers in fragment shaders.
It's possible the 2nd test is not needed as it seems similar things are tested in src/webgpu/api/operation/vertex_state/correctness.spec.ts.
It's also possible the first test's case of seeing that the fragment shader is not called for certain cases is also tested elsewhere.