Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupoorted alignment in execution tests #4145

Conversation

petermcneeleychromium
Copy link
Contributor

Given our spec changes on alignment, an alignment of 1 is invalid.
Since this is an execution test we should simply remove these cases.

If needed we can add additional validation test cases
(eg in webgpu/shader/validation/shader_io/align.spec.ts)

crbug.com/375467276

For reference the error generated when compiling is:

EXCEPTION: Error: Unexpected validation error occurred: Error while parsing WGSL: :7:10 error: alignment must be a multiple of '4' bytes for the 'storage' address space
@align(1) member_0 : i32,
^

:3:23 note: 'MyStruct' used in address space 'storage' here
@group(0) @binding(1) var<storage> input : MyStruct;

@petermcneeleychromium petermcneeleychromium merged commit 8c3c0ff into gpuweb:main Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants