Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_combined_limits operation test. #4144

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

greggman
Copy link
Contributor

This test tests that the combination of maxStorageBuffersInFragmentStage, maxStorageTexturesInFragmentStage, and maxColorAttachments is actually functional.

@greggman greggman requested a review from shrekshao January 11, 2025 00:59
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This test tests that the combination of maxStorageBuffersInFragmentStage,
maxStorageTexturesInFragmentStage, and maxColorAttachments is actually
functional.
@greggman greggman force-pushed the max_combined_limits branch from a58e899 to f9d2fb9 Compare January 15, 2025 18:13
@greggman greggman enabled auto-merge (squash) January 15, 2025 18:13
@greggman greggman merged commit 7ad1454 into gpuweb:main Jan 15, 2025
1 check passed
@greggman greggman deleted the max_combined_limits branch January 15, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants