Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust print_environment for node #4141

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

greggman
Copy link
Contributor

node doesn't have a global navigator variable.

@greggman greggman requested a review from kainino0x January 10, 2025 20:51
node doesn't have a global `navigator` variable.
@greggman greggman force-pushed the fix-print-env-for-dawn.node branch from 0e49a48 to 8dda67e Compare January 10, 2025 21:02
@greggman greggman merged commit dfeea7d into gpuweb:main Jan 10, 2025
1 check passed
@greggman greggman deleted the fix-print-env-for-dawn.node branch January 10, 2025 21:09
@greggman
Copy link
Contributor Author

fyi: I was using this test to verify that --enforce-default-limits was working (cl) when I noticed dawn.node was not making these enumerable. Fixed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants