Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty bind group layout when checking setBindGroup against the… #4134

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

Jiawei-Shao
Copy link
Collaborator

@Jiawei-Shao Jiawei-Shao commented Jan 9, 2025

… pipeline

This patch fixes the tests about checking setBindGroup() against the pipeline with empty bind group layout item. According to the latest WebGPU SPEC, the empty bind group layout item should all be ignored when doing such check.

Fixed: #4075


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [*] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

… pipeline

This patch fixes the tests about checking setBindGroup() against the pipeline with
empty bind group layout item. According to the latest WebGPU SPEC, the empty bind
group layout item should all be ignored when doing such check.
@Jiawei-Shao Jiawei-Shao requested a review from kainino0x January 9, 2025 08:44
@Jiawei-Shao
Copy link
Collaborator Author

@kainino0x PTAL, thanks!

@Jiawei-Shao Jiawei-Shao merged commit 3d039b4 into gpuweb:main Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests about creating pipeline layout with empty bind group layout
2 participants