Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test maxStorage(Buffers/Textures)In(Fragment/Vertex)Stage #4133

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Jan 9, 2025

On Chrome stable the tests are correctly skipped because the limits don't exist.

On Chrome canary the validate test in each fails because canary doesn't enforce that maxXXXInYYYStage must be less than maxXXXPerShaderStage. The auto_upgrade test already passes because of a recent CL.

On a local build with this CL they all pass.

@greggman greggman requested a review from shrekshao January 9, 2025 22:39
@greggman greggman force-pushed the maxStorageBuffersInFragmentStage branch from ef118bb to b7471fa Compare January 10, 2025 21:59
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greggman greggman force-pushed the maxStorageBuffersInFragmentStage branch from b7471fa to 7d66972 Compare January 11, 2025 01:02
@greggman greggman enabled auto-merge (squash) January 11, 2025 01:03
@greggman greggman merged commit 3dd1fec into gpuweb:main Jan 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants