Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment shader tests for subgroup add and mul #4105

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

alan-baker
Copy link
Contributor

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested a review from dneto0 December 18, 2024 15:38
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for testing subgroup add and mul for u32.

Please add TODOs for the other concrete scalar and vector types, then we can land this one. I'm ok delaying writing the remaining cases.

@alan-baker
Copy link
Contributor Author

LGTM for testing subgroup add and mul for u32.

Please add TODOs for the other concrete scalar and vector types, then we can land this one. I'm ok delaying writing the remaining cases.

The data types are tested in other cases. I don't think there's a ton of value in doing a full cross product for types and stages.

@dneto0 dneto0 enabled auto-merge (squash) December 20, 2024 14:16
@dneto0 dneto0 merged commit 9873a0f into gpuweb:main Dec 20, 2024
1 check passed
@alan-baker alan-baker deleted the fragment-add-mul branch December 20, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants